Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated helm dependencies with field to build dependencies #1289

Merged
merged 9 commits into from May 23, 2023

Conversation

denis256
Copy link
Member

@denis256 denis256 commented May 19, 2023

Description

Added to helm.Options flag BuildDependencies to enable helm dependencies building during template rendering, installation, and upgrade.

Fixes #1143.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated helm.Options with flag BuildDependencies, once set, helm chart dependencies building will be performed.

Migration Guide

For helm charts that require dependencies to be built, should be defined helm.BuildDependencies=true

@denis256 denis256 marked this pull request as ready for review May 19, 2023 21:31
@denis256 denis256 requested a review from zackproser as a code owner May 19, 2023 21:31
@denis256 denis256 changed the title Add option to skip helm dependencies building Updated helm dependencies with field to build dependencies May 22, 2023
@denis256 denis256 merged commit e2568de into master May 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable helm dependency build on template rendering
2 participants