Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show line /char numbers with lint issues #73

Merged
merged 1 commit into from
Jul 15, 2016

Conversation

danpoltawski
Copy link
Contributor

We are checking the wrong condition so line/column numbers were never shown.

I considering switching to _.isNumber, but decided to just try the most minimal fix possible..

Steps to reproduce:

  • Use grunt-contrib-csslint on a css file with line errors

Expected results:

  • The line number is reported:
[L15:C5]
>> ERROR: Duplicate property 'color' found. Duplicate properties must appear one after the other. (duplicate-properties) Browsers: All

Actual results:

[GENERAL]
>> ERROR: Duplicate property 'color' found. Duplicate properties must appear one after the other. (duplicate-properties) Browsers: All

Previously we were checking the wrong condition so line/column numbers
were never shown.
@vladikoff vladikoff merged commit f387bb9 into gruntjs:master Jul 15, 2016
@vladikoff
Copy link
Member

Thanks @danpoltawski !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants