[Python Dist] Fix grpc_distribtests_python (v1.63.x backport) #36363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`setuptools` made a decision to change the artifact name it builds (from `grpcio-health-checking` to `grpcio_health_checking`) in their latest release (pypa/setuptools#4300). As a result, we need broaden our regex so that our tests can pickup the correct files. ### Note * Using `[_-]*` instead of `[_-]?` to match one character since `bash` uses a different flavor of regular expressions called basic regular expressions (BREs) which do not support the optional quantifier `?`. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#36352 COPYBARA_INTEGRATE_REVIEW=grpc#36352 from XuanWang-Amos:fix_distribution_test 8dfcc4e PiperOrigin-RevId: 625083784
XuanWang-Amos
added
the
release notes: no
gnossen
approved these changes
Apr 15, 2024
yijiem
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36352 to v1.63.x.
setuptoolsmade a decision to change the artifact name it builds (fromgrpcio-health-checkingtogrpcio_health_checking) in their latest release (pypa/setuptools#4300).As a result, we need broaden our regex so that our tests can pickup the correct files.
Note
[_-]*instead of[_-]?to match one character sincebashuses a different flavor of regular expressions called basic regular expressions (BREs) which do not support the optional quantifier?.