Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] improve possible error message in postfork parent #33791

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Jul 20, 2023

The case of !grpc_ruby_initial_pid() can be a cause of the second case, !grpc_ruby_initial_thread, so check the pid first.

@apolcyn apolcyn added lang/ruby release notes: no Indicates if PR should not be in release notes labels Jul 20, 2023
@apolcyn apolcyn changed the title [rubyu] improve possible error message in postfork parent [ruby] improve possible error message in postfork parent Jul 20, 2023
Copy link
Contributor

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks Alex!

@apolcyn apolcyn merged commit 3d9f2d8 into grpc:master Jul 20, 2023
63 of 64 checks passed
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Jul 20, 2023
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 27, 2023
The case of `!grpc_ruby_initial_pid()` can be a *cause* of the second
case, `!grpc_ruby_initial_thread`, so check the pid first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported Specifies if the PR has been imported to the internal repository lang/ruby release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants