Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "XDS: enable XDS federation by default (#32711)" #32814

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Apr 5, 2023

This reverts commit 4b46dbc.

Reason: this seems to be breaking load reports in certain cases, b/276944116

Let's revert so this doesn't accidentally get released.

@apolcyn apolcyn enabled auto-merge (squash) April 5, 2023 23:16
@apolcyn apolcyn merged commit b0636e7 into grpc:master Apr 6, 2023
11 checks passed
apolcyn added a commit to apolcyn/grpc that referenced this pull request Apr 6, 2023
This reverts commit 4b46dbc.

Reason: this seems to be breaking load reports in certain cases,
b/276944116

Let's revert so this doesn't accidentally get released.
apolcyn added a commit that referenced this pull request Apr 6, 2023
)

This reverts commit 4b46dbc.

Reason: this seems to be breaking load reports in certain cases,
b/276944116

Let's revert so this doesn't accidentally get released.
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Apr 6, 2023
apolcyn added a commit to apolcyn/grpc that referenced this pull request Apr 19, 2023
markdroth pushed a commit that referenced this pull request Apr 20, 2023
…#32814) (#32902)

Previous lack-of-load-reporting issue has been fixed (b/276944116)
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
This reverts commit 4b46dbc.

Reason: this seems to be breaking load reports in certain cases,
b/276944116

Let's revert so this doesn't accidentally get released.
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
…)" (grpc#32814) (grpc#32902)

Previous lack-of-load-reporting issue has been fixed (b/276944116)
wanlin31 pushed a commit that referenced this pull request May 18, 2023
This reverts commit 4b46dbc.

Reason: this seems to be breaking load reports in certain cases,
b/276944116

Let's revert so this doesn't accidentally get released.
wanlin31 pushed a commit that referenced this pull request May 18, 2023
…#32814) (#32902)

Previous lack-of-load-reporting issue has been fixed (b/276944116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants