-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "XDS: enable XDS federation by default (#32711)" #32814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4b46dbc.
apolcyn
added
lang/core
release notes: no
Indicates if PR should not be in release notes
labels
Apr 5, 2023
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
Apr 5, 2023
markdroth
approved these changes
Apr 5, 2023
apolcyn
added a commit
to apolcyn/grpc
that referenced
this pull request
Apr 6, 2023
This reverts commit 4b46dbc. Reason: this seems to be breaking load reports in certain cases, b/276944116 Let's revert so this doesn't accidentally get released.
apolcyn
added a commit
that referenced
this pull request
Apr 6, 2023
copybara-service
bot
added
the
imported
Specifies if the PR has been imported to the internal repository
label
Apr 6, 2023
apolcyn
added a commit
to apolcyn/grpc
that referenced
this pull request
Apr 19, 2023
…rpc#32814)" This reverts commit 4f189b1.
markdroth
pushed a commit
that referenced
this pull request
Apr 20, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
This reverts commit 4b46dbc. Reason: this seems to be breaking load reports in certain cases, b/276944116 Let's revert so this doesn't accidentally get released.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…)" (grpc#32814) (grpc#32902) Previous lack-of-load-reporting issue has been fixed (b/276944116)
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/none
imported
Specifies if the PR has been imported to the internal repository
lang/c++
lang/core
per-call-memory/neutral
per-channel-memory/neutral
release notes: no
Indicates if PR should not be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4b46dbc.
Reason: this seems to be breaking load reports in certain cases, b/276944116
Let's revert so this doesn't accidentally get released.