xDS: Include orca named_metrics in LRS load reports #32690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousukseung
commented
Mar 23, 2023
yousukseung
commented
Mar 23, 2023
yousukseung
commented
Mar 23, 2023
yousukseung
commented
Mar 23, 2023
yousukseung
commented
Mar 23, 2023
yousukseung
commented
Mar 23, 2023
yousukseung
commented
Mar 23, 2023
yousukseung
commented
Mar 23, 2023
yousukseung
commented
Mar 23, 2023
yousukseung
commented
Mar 23, 2023
yousukseung
added
the
release notes: no
yousukseung
requested review from
jtattermusch,
veblush and
gnossen
as code owners
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/medium
labels
yousukseung
force-pushed
the
lrs-named-metrics
branch
from
c3dbe42
to
005284c
Compare
markdroth
changed the title
markdroth
reviewed
Mar 23, 2023
src/core/ext/filters/client_channel/lb_policy/weighted_round_robin/weighted_round_robin.cc
Outdated
Show resolved
Hide resolved
markdroth
reviewed
Mar 24, 2023
src/core/ext/filters/client_channel/lb_policy/weighted_round_robin/weighted_round_robin.cc
Outdated
Show resolved
Hide resolved
yousukseung
force-pushed
the
lrs-named-metrics
branch
from
12692ad
to
ba7e68a
Compare
|
Yousuk, I would ask again that you please not force-push to a branch once a review has started. This makes it very hard for the reviewer to see what has changed since the last review. |
markdroth
reviewed
Mar 27, 2023
src/core/ext/filters/client_channel/lb_policy/weighted_round_robin/weighted_round_robin.cc
Outdated
Show resolved
Hide resolved
|
The EPS PR #32657 has been rolled back, will hold until we roll it forward. |
@markdroth PR is now fully ready (pending tests). |
I removed arg name comments for the matcher instead of adding NOLINT()'s, it looks clang still cannot correctly handle MATCHER macros. |
copybara-service
bot
added
the
imported
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.