grpc-js: Disallow pick_first as child of outlier_detection #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Node's behavior match the other languages. The only effect outlier detection can have with a pick_first child policy is to cause a reconnection if the request failure percentage exceeds a certain value. We only want to support outlier detection for health checking, not for connection management, so that combination is now disallowed.
If the user triggers this by explicitly passing a service config in channel arguments, constructing the channel will throw the error immediately. If they trigger it by providing the service config in a DNS TXT record, it should cause requests to fail with that error.