grpc-js: Fix a couple of things that came up while investigating a memory leak #2456
+31
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first fix, in
client.tsis tonullthecallerStackErrorvariable before theonReceiveStatuscallback returns. TheErrorobject retains information about the stack trace where it was created, including context objects. In the specific case where a new request is initiated while handling the result of a previous request, the new request'scallerStackErrorwould retain a stack context that includes the previouscallerStackError. If done in a ping-pong type loop, this retention could be recursive.The second fix is to ensure that non-OK statuses caused by picker errors (especially if the channel is not connected) are emitted asynchronously. If emitted synchronously, if calls are retried unconditionally and synchronously, the process could make no progress towards reconnecting, resulting in an infinite loop.