grpc-js: Fix address equality check in pick-first #2380
Merged
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2379. In the current code, if the pick-first LB policy gets an address list that is shorter than the previous address list, the loop checking for equality can run off the edge of the list and pass an
undefined
value the type checker doesn't account for intosubchannelAddressEqual
. I added three layers of protection to avoid this:subchannelAddressEqual
is only called if the value is notundefined
.subchannelAddressEqual
can now handleundefined
values, in case something like this happens elsewhere.