Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: add await/async on method that return promise #2376

Merged
merged 1 commit into from Mar 6, 2023

Conversation

phoenix741
Copy link
Contributor

add await/async on method that return promise to ensure that the order of message (and of the end of stream) are preserved

The goal is to fix the ticket #2375 where the end of stream can arrive before last messages and the message can be lost.

add await/async on method that return promise to ensure that the order of message (and of the end of stream) are preserved
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 26, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@phoenix741
Copy link
Contributor Author

Hello,

I'm not sur why the windows build failed. Is it related to the modification of server-call.ts ?

@murgatroid99
Copy link
Member

Don't worry about it. That's an old failure that's unrelated to this change.

@phoenix741
Copy link
Contributor Author

Hello,

Can I afford to ask what is the rest of the process on the PullRequest? (Are we still waiting for something from me to continue)

@murgatroid99
Copy link
Member

I'm sorry about the delay. I'm not waiting on anything from you, I've just been focused on other things.

@murgatroid99
Copy link
Member

I published this in version 1.8.12

@phoenix741
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants