Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Fix commitCallWithMostMessages trying to commit completed attempts #2349

Merged

Conversation

murgatroid99
Copy link
Member

This fixes #2347. The call site of commitCallWithMostMessages assumes that some call has been committed after the function returns. This can fail for two reasons:

  1. All existing underlying calls are completed.
  2. A completed call has more messages sent than all active calls

This change removes the second possibility entirely, and adds checks to handle the first case properly.

@murgatroid99 murgatroid99 merged commit 7ab5368 into grpc:@grpc/grpc-js@1.8.x Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants