grpc-js: Hold a reference to transport in SubchannelCall #2336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2318 (comment) reported a regression in that previously fixed issue. I suspect that the problem is that once a subchannel stops using a transport, nothing has a reference to that transport, which makes it eligible to be garbage collected. To avoid this, the subchannel call now holds a reference to the transport, so it stays alive as long as at least one active call is using it.
I also removed the
disconnectListener
because it became unused in the previous refactor.