Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Error details example #9997

Merged
merged 5 commits into from
Mar 31, 2023
Merged

examples: Error details example #9997

merged 5 commits into from
Mar 31, 2023
+229 −0

Conversation

larry-safran
Copy link
Contributor

@larry-safran larry-safran commented Mar 30, 2023 •
edited
Loading

Show how to use google.rpc.Status returned as the details of io.grpc.Status.

Fixes: b/259311339

@larry-safran
examples: Detail Error example (google.rpc.Status)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
191218f
@larry-safran
fixed

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
272d253
@larry-safran larry-safran added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Mar 30, 2023
@larry-safran larry-safran requested a review from temawi March 30, 2023 23:31
@larry-safran larry-safran marked this pull request as ready for review March 30, 2023 23:31
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Mar 30, 2023
@larry-safran
address code review comments

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
537c42b
@larry-safran
minor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
a14bdac
@larry-safran larry-safran requested a review from temawi March 31, 2023 20:51
temawi
temawi approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the one comment I left, but besides that LGTM.

@larry-safran larry-safran added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Mar 31, 2023
@grpc-kokoro grpc-kokoro removed kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary labels Mar 31, 2023
@larry-safran larry-safran merged commit 10f5e5a into grpc:master Mar 31, 2023
@larry-safran larry-safran deleted the error_details_ex branch June 12, 2023 20:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@temawi temawi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larry-safran @temawi @grpc-kokoro