Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: add missing break in switch statement #9901

Merged
merged 1 commit into from
Feb 17, 2023
Merged

compiler: add missing break in switch statement #9901

merged 1 commit into from
Feb 17, 2023
+1 −0

Conversation

temawi
Copy link
Contributor

@temawi temawi commented Feb 17, 2023

Linters don't like this kind of stuff.

@temawi
compiler: add missing break in switch statement
a03fe39 
Linters don't like this kind of stuff.
ejona86
ejona86 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a case of accidental fallthrough to the linter. We could fix this by adding [[ noreturn ]] to ~LogHelper. But this is fine for a quick fix.

@temawi temawi merged commit d8c572d into grpc:master Feb 17, 2023
@temawi temawi deleted the compiler-add-break branch February 17, 2023 20:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@temawi @ejona86