Skip to content

services: add qps in orca api #9866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Conversation

YifeiZhuang
Copy link
Member

@YifeiZhuang YifeiZhuang commented Feb 1, 2023

Related to cl/500201189
Uses #9862

gRFC: grpc/proposal#343

cc. @ejona86

Verified

This commit was signed with the committer’s verified signature.
liggitt Jordan Liggitt
…api-qps

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ying-jeanne Ying WANG
@YifeiZhuang YifeiZhuang requested a review from temawi February 2, 2023 18:03
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wait for Terry's review.

Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I suggest making the one cleanup I left a comment for.

@YifeiZhuang YifeiZhuang merged commit 6119f6e into grpc:master Feb 2, 2023
@YifeiZhuang YifeiZhuang deleted the orca-api-qps branch February 2, 2023 23:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants