netty: add soft Metadata size limit enforcement. #11603
Merged
+722
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Oct 16, 2024
ejona86
reviewed
Oct 24, 2024
| @@ -217,6 +219,32 @@ public Void answer(InvocationOnMock invocation) throws Throwable { | |||
| channelRead(serializedSettings); | |||
| } | |||
|
|
|||
| @Test | |||
| @SuppressWarnings("InlineMeInliner") | |||
There was a problem hiding this comment.
What was wanting to be inlined?
There was a problem hiding this comment.
The inliner wants me to use string.repeat() instead of Strings.repeat() but that method is JDK 11+. I am not sure we want to use JDK 11 methods even for tests, so I suppressed the warning.
There was a problem hiding this comment.
:-/ . That sort of thing is going to get more annoying. But ignoring it is right. We'll often put a comment on the line with the annotation (e.g., // String.repeat() requires Java 11) to make clear why it is there.
ejona86
approved these changes
Oct 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.