-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SERVLET] Unnecessary bytes to hex string conversion for FINE logging #11031
Labels
Milestone
Comments
hypnoce
added a commit
to hypnoce/grpc-java
that referenced
this issue
Mar 22, 2024
Loading
Loading status checks…
hypnoce
added a commit
to hypnoce/grpc-java
that referenced
this issue
Mar 22, 2024
Loading
Loading status checks…
hypnoce
added a commit
to hypnoce/grpc-java
that referenced
this issue
Mar 22, 2024
Loading
Loading status checks…
Yep. That should be an easy fix. Would you be interested in sending a PR? |
The PR is opened : #11032 |
Oh, the "Fixes X" in is the subject, not in the body, so it didn't link back to this. (Thank you!) |
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this issue
Mar 25, 2024
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this issue
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of gRPC-Java are you using?
1.60.0
What is your environment?
MacOS JDK17
What did you expect to see?
Hex string conversion in when the level is actually FINE:
grpc-java/servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
Line 108 in 3abab95
What did you see instead?
Hex string conversion before checking log level
Steps to reproduce the bug
The text was updated successfully, but these errors were encountered: