lb: acceptResolvedAddresses() to return Status #10636
Merged
+299
−274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a
boolean
,LoadBalancer.acceptResolvedAddresses()
now return a Status object.Status.OK
represents accepted addresses and others non-acceptance. This allows the LB to provide more information about why a set of addresses were not acceptable.The status will later be sent to the name resolver as well to allow it to also better react to to bad addresses.