Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lb: acceptResolvedAddresses() to return Status #10636

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

temawi
Copy link
Contributor

@temawi temawi commented Oct 28, 2023

Instead of a boolean, LoadBalancer.acceptResolvedAddresses() now return a Status object. Status.OK represents accepted addresses and others non-acceptance. This allows the LB to provide more information about why a set of addresses were not acceptable.

The status will later be sent to the name resolver as well to allow it to also better react to to bad addresses.

@temawi temawi force-pushed the boolean-to-status branch 2 times, most recently from 9d702a6 to c5347e5 Compare October 28, 2023 23:37
Instead of a boolean, we now return a Status object. Status.OK
represents accepted addresses and other non-acceptance. This allows the
LB to provide more information about why a set of addresses were not
acceptable.

The status will later be sent to the name resolver as well to allow it
to also better react to to bad addresses.
@temawi temawi force-pushed the boolean-to-status branch from c5347e5 to 656cf1a Compare October 29, 2023 00:14
@temawi temawi requested a review from ejona86 October 29, 2023 01:16
@temawi temawi merged commit 9888a54 into grpc:master Nov 3, 2023
@temawi temawi deleted the boolean-to-status branch November 3, 2023 16:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants