Log ORCA UNIMPLEMENTED error to subchannel logger #10625
Merged
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging to the static instance would result in application logs filling up if the Orca service is not available. We'd like to have the logging on the subchannelLogger, so we make it visible on demand.
Using contains over containsExactly seems more reasonable.
yannickepstein
commented
Oct 24, 2023
| @@ -153,7 +153,7 @@ private static OrcaLoadReportRequest buildOrcaRequestFromConfig( | |||
| } | |||
|
|
|||
| private static void assertLog(List<String> logs, String expectedLog) { | |||
| assertThat(logs).containsExactly(expectedLog); | |||
| assertThat(logs).contains(expectedLog); | |||
There was a problem hiding this comment.
This might be a questionable change, but I think this is the better way to test if a log message is present. However, I can rework this if needed.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
Oct 25, 2023
|
Thank you! |
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this pull request
Oct 26, 2023
Logging to the static instance would result in application logs filling up if the Orca service is not available. We'd like to have the logging on the subchannelLogger, so we make it visible on demand. Also succeed Orca logging test if log message present. Using contains over containsExactly seems more reasonable.
YifeiZhuang
pushed a commit
that referenced
this pull request
Oct 26, 2023
Logging to the static instance would result in application logs filling up if the Orca service is not available. We'd like to have the logging on the subchannelLogger, so we make it visible on demand. Also succeed Orca logging test if log message present. Using contains over containsExactly seems more reasonable. Co-authored-by: Yannick Epstein <yannick.epstein@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started using Orca, but not every service in our service mesh serves an Orca endpoint.
This means that our client side logs filled up with severe logging messages about the Orca service being
UNIMPLEMENTEDper subchannel.This is because the error is the only one that is logged to a static Java logger instance, while the rest of the subchannel messages are logged to the
SubchannelLogger.In order to not fill up the logs of our services, we'd like to also log the
UNIMPLEMENTEDerror to theSubchannelLogger.