Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a single SETTINGS frame from Netty #1059

Closed
nmittler opened this issue Sep 22, 2015 · 0 comments
Closed

Send a single SETTINGS frame from Netty #1059

nmittler opened this issue Sep 22, 2015 · 0 comments
Assignees
@nmittler
Labels
enhancement
Milestone
0.12.0

Comments

@nmittler
Copy link
Member

We have an old TODO to update Netty once we upgrade to 4.1.0.Beta6 (which we have done):

grpc-java/netty/src/main/java/io/grpc/netty/NettyClientHandler.java

Line 134 in aefefb5

// TODO(nmittler): this is a temporary hack as we currently have to send a 2nd SETTINGS
.
@nmittler nmittler self-assigned this Sep 22, 2015
@nmittler nmittler added this to the 0.10.0 milestone Sep 22, 2015
nmittler pushed a commit to nmittler/grpc-java that referenced this issue Sep 23, 2015
Updating Netty to send a single SETTINGS frame.
9003c21 
Fixes grpc#1059
@nmittler nmittler mentioned this issue Sep 23, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nmittler nmittler

Labels
enhancement
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
1 participant
@nmittler