Update binderDied() error description to spell out the possibilities for those unfamiliar with Android internals. (#11628)

jdcormie · web-flow · commit 46c1b387fa54 · 2024-10-24T10:52:44.000-07:00
Callers are frequently confused by this message and waste time looking for problems in the client when the root cause is simply a server crash. See b/371447460 for more context.
diff --git a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java
@@ -299,7 +299,7 @@ protected boolean setOutgoingBinder(OneWayBinderProxy binder) {
 
   @Override
   public synchronized void binderDied() {
-    shutdownInternal(Status.UNAVAILABLE.withDescription("binderDied"), true);
+    shutdownInternal(Status.UNAVAILABLE.withDescription("Peer process crashed, exited or was killed (binderDied)"), true);
   }
 
   @GuardedBy("this")

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ protected boolean setOutgoingBinder(OneWayBinderProxy binder) {`
`299`	`299`
`300`	`300`	`@Override`
`301`	`301`	`public synchronized void binderDied() {`
`302`		`- shutdownInternal(Status.UNAVAILABLE.withDescription("binderDied"), true);`
	`302`	`+ shutdownInternal(Status.UNAVAILABLE.withDescription("Peer process crashed, exited or was killed (binderDied)"), true);`
`303`	`303`	`}`
`304`	`304`
`305`	`305`	`@GuardedBy("this")`