Skip to content

Commit 21dec30

Browse files
authoredJul 9, 2024··
Establish a default connect timeout. (#11359)
Enables the timer added in #11137
1 parent 0ff3f8e commit 21dec30

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎binder/src/main/java/io/grpc/binder/internal/BinderClientTransportFactory.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public static final class Builder implements ClientTransportFactoryBuilder {
127127
BindServiceFlags bindServiceFlags = BindServiceFlags.DEFAULTS;
128128
InboundParcelablePolicy inboundParcelablePolicy = InboundParcelablePolicy.DEFAULT;
129129
OneWayBinderProxy.Decorator binderDecorator = OneWayBinderProxy.IDENTITY_DECORATOR;
130-
long readyTimeoutMillis = -1; // TODO(jdcormie) Set an non-infinite default in a separate PR.
130+
long readyTimeoutMillis = 60_000;
131131

132132
@Override
133133
public BinderClientTransportFactory buildClientTransportFactory() {
@@ -210,7 +210,7 @@ public Builder setBinderDecorator(OneWayBinderProxy.Decorator binderDecorator) {
210210
* <a href="https://github.com/grpc/grpc/blob/master/doc/wait-for-ready.md">fail-fast</a> work
211211
* as expected despite certain edge cases that could otherwise stall the transport indefinitely.
212212
*
213-
* <p>Optional. Use a negative value to wait indefinitely.
213+
* <p>Optional but enabled by default. Use a negative value to wait indefinitely.
214214
*/
215215
public Builder setReadyTimeoutMillis(long readyTimeoutMillis) {
216216
this.readyTimeoutMillis = readyTimeoutMillis;

0 commit comments

Comments
 (0)
Please sign in to comment.