Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channelz: add LocalAddr to listen sockets and test (#7062) #7063

Merged
merged 1 commit into from Mar 22, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Mar 22, 2024

Cherry-pick bug fix PR #7062 to v1.63.x

RELEASE NOTES: none

@dfawley dfawley added this to the 1.63 Release milestone Mar 22, 2024
@dfawley dfawley requested a review from zasweq March 22, 2024 20:25
@zasweq
Copy link
Contributor

zasweq commented Mar 22, 2024

LGTM.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #7063 (fd93394) into v1.63.x (4ffccf1) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.63.x    #7063      +/-   ##
===========================================
- Coverage    82.62%   82.35%   -0.28%     
===========================================
  Files          300      300              
  Lines        31351    31357       +6     
===========================================
- Hits         25905    25825      -80     
- Misses        4401     4466      +65     
- Partials      1045     1066      +21     
Files Coverage Δ
server.go 81.36% <100.00%> (-0.79%) ⬇️

... and 22 files with indirect coverage changes

@dfawley dfawley merged commit e62770d into grpc:v1.63.x Mar 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants