channelz: add LocalAddr to listen sockets and test #7062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7062 +/- ##
==========================================
+ Coverage 82.49% 82.58% +0.08%
==========================================
Files 300 300
Lines 31351 31357 +6
==========================================
+ Hits 25864 25896 +32
+ Misses 4434 4409 -25
+ Partials 1053 1052 -1
|
|
For posterity: the regression introduced in #6969, internal ref b/330220025. |
zasweq
approved these changes
Mar 21, 2024
test/channelz_test.go
Outdated
Comment on lines
223
to
228
| return false, fmt.Errorf("server want id %d, but got %d", serverID, srv.ID) | ||
| } | ||
|
|
||
| skts := srv.ListenSockets() | ||
| if got, want := len(skts), 1; got != want { | ||
| return false, fmt.Errorf("server has %v sockets; want %v", got, want) |
There was a problem hiding this comment.
Optional nit: keep consistent with go style guide and also I prefer consistent format across errors (and our codebase): https://g3doc.corp.google.com/go/g3doc/style/decisions.md?cl=head#got-before-want
|
Merged; hopefully tests pass now :) |
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Mar 22, 2024
dfawley
added a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: none