Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googlec2p: use xdstp style template for client LDS resource name #7048

Merged
merged 2 commits into from Mar 19, 2024

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented Mar 19, 2024

The google c2p resolver should be using the new xdstp style names for LDS resource names. Also adds "xds.config.resource-in-sotw" to server_features which is also required by the google c2p resolver.

RELEASE NOTES: none

@arvindbr8 arvindbr8 requested a review from apolcyn March 19, 2024 20:46
@arvindbr8 arvindbr8 added the Type: Behavior Change Behavior changes not categorized as bugs label Mar 19, 2024
@arvindbr8 arvindbr8 added this to the 1.63 Release milestone Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #7048 (81866ee) into master (dadbbfa) will increase coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7048      +/-   ##
==========================================
+ Coverage   82.45%   82.49%   +0.03%     
==========================================
  Files         299      300       +1     
  Lines       31314    31351      +37     
==========================================
+ Hits        25819    25862      +43     
+ Misses       4435     4431       -4     
+ Partials     1060     1058       -2     
Files Coverage Δ
xds/googledirectpath/googlec2p.go 84.70% <100.00%> (+0.18%) ⬆️

... and 23 files with indirect coverage changes

@arvindbr8 arvindbr8 requested a review from apolcyn March 19, 2024 20:50
@arvindbr8 arvindbr8 merged commit 4ffccf1 into grpc:master Mar 19, 2024
14 checks passed
@arvindbr8 arvindbr8 deleted the fix_c2p branch March 19, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants