deps: fix backwards compatibility with encoding #6965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Feb 5, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6965 +/- ##
==========================================
- Coverage 83.70% 83.69% -0.02%
==========================================
Files 288 288
Lines 30921 30929 +8
==========================================
+ Hits 25883 25885 +2
- Misses 3976 3983 +7
+ Partials 1062 1061 -1
|
dfawley
reviewed
Feb 5, 2024
| var vv proto.Message | ||
| vv := messageV2Of(v) | ||
| if vv == nil { | ||
| return fmt.Errorf("failed to marshal, message is %T, want proto.Message", v) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
encoding/proto.gowhen Marshal() and Unmarshal() we should be able to handle both v1 and v2 of proto messages. But in #6919 we broke backwards compatibility of able to handle v1 proto messages. This change fixes that.cc: @Clement-Jean
RELEASE NOTES: none