grpc: Add StaticMethod CallOption #6926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6926 +/- ##
==========================================
- Coverage 83.51% 82.27% -1.25%
==========================================
Files 287 296 +9
Lines 30920 31454 +534
==========================================
+ Hits 25824 25878 +54
- Misses 4020 4505 +485
+ Partials 1076 1071 -5
|
zasweq
commented
Jan 24, 2024
dfawley
reviewed
Feb 5, 2024
|
Added. |
|
Let me know if you want to still change the name of this Call Option. |
dfawley
reviewed
Feb 14, 2024
rpc_util.go
Outdated
| // RegisteredMethod returns a CallOption which specifies that a call comes from | ||
| // a registered method. This does nothing functionally, but serves as a signal | ||
| // to other code. | ||
| func RegisteredMethod() CallOption { |
There was a problem hiding this comment.
StaticMethod, as discussed offline.
zasweq
changed the title
dfawley
approved these changes
Feb 14, 2024
rpc_util.go
Outdated
Comment on lines
202
to
205
| type StaticMethodCallOption struct{} | ||
|
|
||
| func (StaticMethodCallOption) before(*callInfo) error { return nil } | ||
| func (StaticMethodCallOption) after(*callInfo, *csAttempt) {} |
There was a problem hiding this comment.
Let's do:
type StaticMethodCallOption struct {
EmptyCallOption
}(Then there is no need for before/after to be declared.)
rpc_util.go
Outdated
Comment on lines
193
to
194
| // to a method that is static, which the method is known at compile time and | ||
| // doesn't change at runtime. This can be used as a signal to stats plugins that |
There was a problem hiding this comment.
"that is static, which means ..."?
dfawley
changed the title
dfawley
reviewed
Feb 15, 2024
zasweq
added a commit
to zasweq/grpc-go
that referenced
this pull request
Feb 15, 2024
zasweq
added a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a call option that specifies whether a method is static. This is intended to be used by generated code and users to get a method attribute within OpenTelemetry while protecting the cardinality of OpenTelemetry timeseries.
RELEASE NOTES: