Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LocalAddr to http2Client.getPeer() #6779

Merged
merged 1 commit into from Nov 10, 2023
Merged

Add LocalAddr to http2Client.getPeer() #6779

merged 1 commit into from Nov 10, 2023

Conversation

CarlosRDomin
Copy link
Contributor

@CarlosRDomin CarlosRDomin commented Nov 9, 2023 •
edited by zasweq

Fixes #6577.

Followup to #6716 that exposes LocalAddr also to grpc clients (#6716 only exposed it to servers). Release note in #6716 encapsulates this logic as well.

RELEASE NOTES: n/a

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 9, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: CarlosRDomin / name: Carlos Ruiz (574393c)

@CarlosRDomin CarlosRDomin force-pushed the feat/expose-local-addr-in-http2-client branch from e0e4968 to 574393c Compare November 9, 2023 23:37
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited

Codecov Report

Merging #6779 (574393c) into master (be1d1c1) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6779      +/-   ##
==========================================
+ Coverage   83.34%   83.45%   +0.10%     
==========================================
  Files         285      285              
  Lines       30966    30967       +1     
==========================================
+ Hits        25809    25842      +33     
+ Misses       4076     4052      -24     
+ Partials     1081     1073       -8
Files Coverage Δ
internal/transport/http2_client.go 90.07% <100.00%> (-0.31%) ⬇️

... and 21 files with indirect coverage changes

@CarlosRDomin CarlosRDomin mentioned this pull request Nov 9, 2023
Closed
@zasweq zasweq added the Type: Feature New features or improvements in behavior label Nov 10, 2023
@zasweq zasweq self-requested a review November 10, 2023 00:37
@zasweq zasweq self-assigned this Nov 10, 2023
@zasweq zasweq requested a review from dfawley November 10, 2023 00:37
@zasweq zasweq added this to the 1.60 Release milestone Nov 10, 2023
zasweq
zasweq approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Giving to Doug for a second review.

@zasweq zasweq removed their assignment Nov 10, 2023
@dfawley dfawley merged commit 591c481 into grpc:master Nov 10, 2023
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@zasweq zasweq zasweq approved these changes

Assignees

@dfawley dfawley

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.60 Release
Development

Successfully merging this pull request may close these issues.

add LocalAddr to peer.Peer client side
3 participants
@CarlosRDomin @dfawley @zasweq