Revert "status: fix/improve status handling (#6662)" #6673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0772ed7.
easwars
approved these changes
Oct 2, 2023
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Oct 2, 2023
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Oct 4, 2023
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Oct 4, 2023
dfawley
added a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0772ed7 (by re-applying #6662).
It does not, however, enforce that a status code sent or received is within the acceptable range (1-16) and convert to Unknown if it is not. Other values can be used, though they shouldn't, and we reserve the right to change this behavior in the future. See https://github.com/grpc/grpc/blob/master/doc/statuscodes.md for more details.
RELEASE NOTES: none