balancer/leastrequest: Add least request balancer #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
changed the title
dfawley
reviewed
Aug 10, 2023
zasweq
force-pushed
the
least-request-balancer
branch
from
93db4be
to
0ce88c9
Compare
dfawley
reviewed
Aug 10, 2023
dfawley
reviewed
Aug 11, 2023
Comment on lines
302
to
307
| defer func() { | ||
| stream.CloseSend() | ||
| if _, err = stream.Recv(); err != io.EOF { | ||
| t.Fatalf("unexpected error: %v, expected an EOF error", err) | ||
| } | ||
| }() |
There was a problem hiding this comment.
I think we can just delete all of this and rely on ctx's cancelation to clean up everything.
Same with the other test. Just make the server's handler do a <-stream.Context().Done() instead of doing a stream.Recv() in a loop.
| stream.CloseSend() // Finish stream to populate peer. | ||
| if _, err = stream.Recv(); err != io.EOF { | ||
| t.Fatalf("unexpected error: %v, expected an EOF error", err) | ||
| defer func() { |
| if err != nil { | ||
| t.Fatalf("testServiceClient.FullDuplexCall failed: %v", err) | ||
| } | ||
| defer func() { |
dfawley
approved these changes
Aug 11, 2023
| gotAddrCount[p.Addr.String()]++ | ||
| } | ||
| } | ||
| if diff := cmp.Diff(gotAddrCount, wantAddrCount); diff != "" { |
There was a problem hiding this comment.
Nit: if you're not showing the diff, just use !cmp.Equal() instead. (Also in checkRoundRobin.)
There was a problem hiding this comment.
Printed diff here. In check round robin no need for diff so just used !cmp.Equal().
Comment on lines
+449
to
+452
| if !ok { | ||
| t.Fatalf("testServiceClient.FullDuplexCall has no Peer") | ||
| } | ||
| if p.Addr != nil { |
There was a problem hiding this comment.
Optional: IMO it's cleaner to remove the defensive programming and just let things panic if they're breaking assertions:
p, _ := peer.FromContext(stream.Context)
gotAddrCount[p.Addr.String()]++But this is fine, too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the least request load balancer, speced in https://github.com/grpc/proposal/blob/master/A48-xds-least-request-lb-policy.md.
RELEASE NOTES: