Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PSM interop] Don't fail target if sub-target already failed #6390

Merged
merged 1 commit into from Jun 23, 2023
Merged

[PSM interop] Don't fail target if sub-target already failed #6390

merged 1 commit into from Jun 23, 2023

Conversation

XuanWang-Amos
Copy link
Contributor

We don't want file multiple bugs if any of the sub-tests of the url_map test fails.

The same change in core: grpc/grpc#33520.

RELEASE NOTES: N/A

zasweq
zasweq approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zasweq zasweq added this to the 1.57 Release milestone Jun 23, 2023
@zasweq zasweq merged commit 10f5b50 into grpc:master Jun 23, 2023
11 checks passed
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
9bc1ccf
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
2aa3a27
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
3840481
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
edf99cd
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
b2f6a10
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
ad75714
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
cccbf23
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
15726ba
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
96125cd
This was referenced Jun 23, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
1de799c
@XuanWang-Amos XuanWang-Amos mentioned this pull request Jun 23, 2023
Merged
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
623c2b9
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
ed56401 
…6405)
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
2c435a1
XuanWang-Amos added a commit to XuanWang-Amos/grpc-go that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (grpc#6390)
ddc8bfa
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
edec176 
…6404)
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
569da3e 
…6403)
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
d84102e 
…6402)
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
311d94b 
…6401)
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
1d1a72d 
…6400)
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
dbaad28 
…6399)
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
960c580 
…6398)
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
2ed2cb8 
…6397)
zasweq pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#6390) (#…
f05f7ac 
…6396)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zasweq zasweq zasweq approved these changes

Assignees
No one assigned
Labels
Type: Testing
Projects
None yet
Milestone
1.57 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XuanWang-Amos @zasweq