internal/envconfig: Set Custom LB Env Var to true by default #6317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
May 25, 2023
internal/envconfig/xds.go
Outdated
| @@ -89,7 +89,7 @@ var ( | |||
| // C2PResolverTestOnlyTrafficDirectorURI is the TD URI for testing. | |||
| C2PResolverTestOnlyTrafficDirectorURI = os.Getenv("GRPC_TEST_ONLY_GOOGLE_C2P_RESOLVER_TRAFFIC_DIRECTOR_URI") | |||
| // XDSCustomLBPolicy indicates whether Custom LB Policies are enabled, which | |||
| // can be enabled by setting the environment variable | |||
| // can be disabled by setting the environment variable | |||
| // "GRPC_EXPERIMENTAL_XDS_CUSTOM_LB_CONFIG" to "true". | |||
Comment on lines
94
to
99
| oldCustomLBSupport := envconfig.XDSCustomLBPolicy | ||
| envconfig.XDSCustomLBPolicy = true | ||
| defer func() { | ||
| envconfig.XDSCustomLBPolicy = oldCustomLBSupport | ||
| }() | ||
|
|
There was a problem hiding this comment.
Probably would be best to leave these in there until the env var is removed. Otherwise the tests will fail if you disable it in your environment.
There was a problem hiding this comment.
Deleted these (by git checkout master ./) lol
dfawley
approved these changes
May 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the Custom LB Env Var to true by default. This functionality has been tested in interop, and is stable.
RELEASE NOTES: