Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xDS: Fix Outlier Detection Config Handling #6274

Closed
zasweq opened this issue May 12, 2023 · 2 comments
Closed

xDS: Fix Outlier Detection Config Handling #6274

zasweq opened this issue May 12, 2023 · 2 comments
Assignees

Comments

@zasweq
Copy link
Contributor

zasweq commented May 12, 2023

Things needed to be fixed:

  • The preparation of the config needs to account for xDS Defaults, which prepares the success rate ejection and failure percentage ejection algorithms based on zero/null values in management server protos
  • Communicate the configuration to CDS balancer through JSON, rather than an internal struct, that takes into account for xDS Defaults.
  • Parse the Configuration into the Outlier Detection config by calling ParseConfig on Outlier Detection in CDS, thus CDS needs to hold onto an Outlier Detection configuration parser
  • Outlier Detection needs to set defaults in ParseConfig, not xDS unmarshaling, like WRR.
  • Fix no-op configuration (no fields set at all)
@zasweq zasweq self-assigned this May 12, 2023
@zasweq
Copy link
Contributor Author

zasweq commented May 16, 2023

Discussed offline; set defaults in ParseConfig based off presence, flattening of configuration list in xDS Client (which account for xDS/Envoy defaults).

@zasweq zasweq changed the title Switch Outlier Detection to set defaults in ParseConfig, not xDS unmarshaling xDS: Fix Outlier Detection Config Handling May 31, 2023
@zasweq
Copy link
Contributor Author

zasweq commented Jun 12, 2023

Fixed by #6361.

@zasweq zasweq closed this as completed Jun 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant