xds: enable XDS federation by default #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
reviewed
Mar 24, 2023
| defer func() func() { | ||
| oldEnv := envconfig.XDSFederation | ||
| envconfig.XDSFederation = true | ||
| envconfig.XDSFederation = false |
There was a problem hiding this comment.
Should we fix the failing test instead of disabling federation for the duration of this test?
There was a problem hiding this comment.
Sorry I might be reading this wrong - this should only be disabling federation for the duration of the one test case that explicitly disables it, no?
There was a problem hiding this comment.
Oh sorry, I missed the if !tt.env.
Can we simplify this by getting rid of the if !tt.env?
oldEnv := envconfig.XDSFederation
envconfig.XDSFederation = tt.env
defer func() { envconfig.XDSFederation = oldEnv }()
easwars
approved these changes
Mar 24, 2023
|
Thanks for the review @easwars. Please merge if this looks good to you (I don't have write access) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests have been green, so let's enable this (verification of recent test results in https://b.corp.google.com/issues/262593165#comment31).
cc @easwars
RELEASE NOTES: