credentials/alts: defer ALTS stream creation until handshake time #6077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindbr8
requested changes
Mar 3, 2023
|
cc: @apolcyn |
|
@arvindbr8 I saw you added the "Status: Requires Report Clarification" tag: please let me know what you'd like me to clarify. :) |
apolcyn
reviewed
Mar 6, 2023
apolcyn
approved these changes
Mar 7, 2023
easwars
requested changes
Mar 14, 2023
|
Also, is the title of the PR up-to-date? I don't any see lock being involved here. |
matthewstevenson88
changed the title
The lock is hidden under the call to acquire(). Updated the title to clarify. :) |
matthewstevenson88
requested review from
easwars
and removed request for
arvindbr8
easwars
changed the title
easwars
approved these changes
Mar 16, 2023
arvindbr8
approved these changes
Mar 16, 2023
|
Thanks all for the reviews! @arvindbr8 or @easwars: would one of you be able to merge the PR? I'm afraid I don't have write access. :) |
matthewstevenson88
added a commit
to matthewstevenson88/grpc-go
that referenced
this pull request
Apr 10, 2023
easwars
added a commit
that referenced
this pull request
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code creates the stream to the ALTS handshaker service before checking that we are not exceeding the max number of concurrent connections, which defeats the purpose of having the max pending handshakes cap.
While we're here, I also lower themaxPendingHandshakescap to 40, to match up with the C-core code and with the current expectations of the ALTS handshaker service. (We will be lowering this cap again in the future.)RELEASE NOTES: none