resolver: update Resolver.Scheme() docstring to mention requirement of lowercase scheme names #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also recommend Scheme() to return no uppercase letters, as RFC3986 requires parsing to convert the scheme to lowercase Fixes grpc#6011.
arvindbr8
approved these changes
Feb 10, 2023
arvindbr8
approved these changes
Feb 10, 2023
resolver_test.go
Outdated
| @@ -88,10 +89,15 @@ func (s) TestResolverCaseSensitivity(t *testing.T) { | |||
| // globally-registered resolver. Since it is "dns" instead of passthrough, | |||
| // we can validate by checking for an address that has been resolved | |||
| // (i.e. is not "localhost:port"). | |||
| cc, err = Dial(target, WithContextDialer(customDialer), WithResolvers(res), WithTransportCredentials(insecure.NewCredentials())) | |||
|
|
|||
| // WithDisableServiceConfig disables TXT lookups, which can hang for | |||
|
oh wait, seems like the tests are still failing with a similar pattern |
|
all tests are green now |
dfawley
changed the title
dfawley
added
Type: Documentation
|
PTAL after the changes as discussed earlier today. |
arvindbr8
approved these changes
Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also test the case-senstiveness of the checks.
Fixes #6011.
RELEASE NOTES: