Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: after GracefulStop, ensure connections are closed when final RPC completes #5968

Merged
merged 1 commit into from Jan 26, 2023
Merged

server: after GracefulStop, ensure connections are closed when final RPC completes #5968

merged 1 commit into from Jan 26, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jan 24, 2023 •
edited

Fixes #5930

RELEASE NOTES:

  • server: after GracefulStop, ensure connections are closed when final RPC completes

@dfawley dfawley added this to the 1.53 Release milestone Jan 24, 2023
@dfawley dfawley merged commit 2a1e934 into grpc:master Jan 26, 2023
1 check passed
@dfawley dfawley deleted the serverdrainclose branch January 26, 2023 00:28
@dfawley dfawley mentioned this pull request Feb 16, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@arvindbr8 arvindbr8

Labels
Type: Bug
Projects
None yet
Milestone
1.53 Release
Development

Successfully merging this pull request may close these issues.

GracefulStop hangs forever if the client doesn't the close underlying tcp connection.
2 participants
@dfawley @arvindbr8