Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding: fix duplicate compressor names #5958

Merged
merged 2 commits into from Jan 24, 2023
Merged

encoding: fix duplicate compressor names #5958

merged 2 commits into from Jan 24, 2023

Conversation

jronak
Copy link
Contributor

@jronak jronak commented Jan 23, 2023

Previously, registering multiple compressors with the same name would append the name repeatedly in RegisteredCompressorNames. This PR fixes it.

RELEASE NOTES: N/A

@jronak jronak mentioned this pull request Jan 23, 2023
Merged
easwars
easwars reviewed Jan 23, 2023
View reviewed changes
encoding/encoding_test.go Outdated Show resolved Hide resolved
@easwars easwars added this to the 1.53 Release milestone Jan 23, 2023
easwars
easwars approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the use of cmp package instead of reflect.

@easwars easwars requested a review from dfawley January 23, 2023 18:56
dfawley
dfawley approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the fix!

@dfawley dfawley merged commit e5a0237 into grpc:master Jan 24, 2023
1 check passed
@jronak jronak deleted the fix-compressor-registry branch January 24, 2023 17:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

@dfawley dfawley dfawley approved these changes

Assignees

@jronak jronak

@dfawley dfawley

Labels
Type: Bug
Projects
None yet
Milestone
1.53 Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jronak @easwars @dfawley @arvindbr8