gcp/observability: update method name validation #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the tests are now failing here. |
zasweq
force-pushed
the
leading-slash-fix
branch
3 times, most recently
from
2daf783
to
8b823e5
Compare
dfawley
changed the title
dfawley
approved these changes
Jan 23, 2023
gcp/observability/config.go
Outdated
| // validateMethodString validates whether the string passed in is a valid | ||
| // pattern. | ||
| func validateMethodString(method string) error { | ||
| if method == "*" { |
There was a problem hiding this comment.
Note that this function isn't even called if method is *.
Maybe inline this in validateLogEventMethod?
There was a problem hiding this comment.
Yeah fair point missed that. I'm assuming inline this means just leave what is there (if * continue (skip calling this function/validating). Deleted this conditional.
gcp/observability/logging.go
Outdated
| // parseMethod splits service and method from the input. It expects format | ||
| // "service/method". | ||
| func parseMethod(method string) (string, string, error) { | ||
| pos := strings.LastIndex(method, "/") |
There was a problem hiding this comment.
Nit: maybe Index is a little less unusual than LastIndex since we know there is exactly one slash.
There was a problem hiding this comment.
Ah good point already validated by this point. Switched.
zasweq
force-pushed
the
leading-slash-fix
branch
from
8b823e5
to
f9905ea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR iterates what a valid method name is in the observability config, according to offline discussions.
From Doug, this can be summarized as:
RELEASE NOTES: