Trim regex from Grpc.AspNetCore #2326
Merged
+85
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
mgravell,
ReubenBond,
BrennanConroy and
amcasey
JamesNK
force-pushed
the
jamesnk/aot-trim-regex
branch
from
df96209 to
2e499ab
Compare
|
Ping for review now that holidays are over. The changes are in GrpcServiceExtensions.cs. Everything else is for testing. |
BrennanConroy
approved these changes
Nov 28, 2023
|
I don't think it is worth calling out. Regex route would never be used with gRPC (it defines routes for you) and if you have regex in routes in another framework, e.g. MVC, Minimal API, then that framework or hosting will already be calling |
oguzhand95
referenced
this pull request
in cerbos/cerbos-sdk-net
Jan 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Grpc.Net.Client](https://togithub.com/grpc/grpc-dotnet) | `2.59.0` -> `2.60.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary> ### [`v2.60.0`](https://togithub.com/grpc/grpc-dotnet/releases/tag/v2.60.0) #### What's Changed - Update to GA .NET 8 SDK by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2321](https://togithub.com/grpc/grpc-dotnet/pull/2321) - Update to use Directory.Packages.props by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2315](https://togithub.com/grpc/grpc-dotnet/pull/2315) - Add Native AOT test by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2324](https://togithub.com/grpc/grpc-dotnet/pull/2324) - Trim regex from Grpc.AspNetCore by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2326](https://togithub.com/grpc/grpc-dotnet/pull/2326) **Full Changelog**: grpc/grpc-dotnet@v2.59.0...v2.60.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-net). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddGrpccallsAddRoutingto configure a route constraint. This is a problem when publishing with trimming/AOT becauseAddRoutingregisters the regex route constraint.Configure
RouteOptionsdirectly and rely on the host to add routing. If the host is created with slim builder, then regex is never referenced and can be trimmed away.I confirmed regex is trimmed after this change with sizoscope: