Use appropriate class loader for servermanger commands #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smhc thanks for that! Seems good to me. You could extract a method that does that (although I don't see a good way of reusing it in the already-existing place). @f4lco please take a look and give your opinion - you definitely know the code better than me. I guess it makes sense that all |
|
Thanks again for this and sorry for taking so long to merge it! @f4lco please take a look when you can and we can always fix anything you want after that. :) |
|
Thank you so much @smhc for your contribution. Indeed, the missing guards have been an oversight! |
|
Released in 4.1.1. Thanks! |
|
Will there be a 3.x release with theses changes? |
|
@smhc I've released 3.1.2. Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional change to address restart issues with issue 293