Support graphql-transport-ws websocket protocol #539
Merged
+1,031
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…previous dependant code
…pWebSocket into two classes (one per protocol) that inherit from BaseGraphQLHttpWebSocket
… +semver: breaking
Closed
I think that's a good idea. I could implement the same in GraphQL.NET Server 7, although it is not so now. |
|
Just FYI, when server-side keep-alive is enabled within GraphQL.NET Server 7, only pongs are sent, and only when the specified amount of time has elapsed from the last sent or received message. |
|
Any plans to support protocol auto negotiations @rose-a ? |
|
Already implemented and enabled by default in v6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up #493, rebases on current master, adds unit tests, resolves the errors and does some refactoring.
Not yet implemented:
@Shane32 Regarding ping/pong whats your opinion on how the payload of a ping should be handled? Its not explicitly stated in the spec, but my current implementation reflects the payload of the ping request in the corresponding pong request.
Since the spec explicitly allows sending pongs at any time, this allows the server to correlate pongs with sent pings to use this for metrics etc.