ci: VERSION_DETAILS does not contain the latest tag

[codebien]

During the build the new tag hasn't been picked from the git describe command, in this way the k6 version prints an older tag. It isn't a critical bug because all the important information like the date or the commit hash are correct.

The issue could be related to the GitHub checkout action that doesn't fetch for a strange reason the latest created tag.

k6 version
k6 v0.40.0 (2022-09-08T09:06:02+0000/v0.39.0-92-gdcbe2f9c, go1.18.6, linux/amd64)

Current

v0.39.0-92-gdcbe2f9c

Expected

v0.40.0-0-gdcbe2f9c

[na--]

Potentially relevant issues: actions/checkout#882, actions/checkout#701

[na--]

Decided to dig this a little deeper and we can actually see all of the git actions that were executed by the v0.40.0 build 🎉 And this seems like the reason for the problem to me: https://github.com/grafana/k6/runs/8245641202?check_suite_focus=true#step:2:620

In case that log disappears, I'll post the raw logs and a screenshot here as well:

v0.40.0-build.log

[na--]

The question is, why was this not a problem in previous builds and became a problem for v0.40.0? 🤔 I assume I broke something with the (now notorious) #2591, but I am not sure exactly what... 😕

[mstoykov]

Was this same command executed in the previous releases? Or did something change in the github-action, maybe outside the changes in our workflow?

[olegbespalov]

I can guess that it's broken since, for the version details, we don't pass the --tags (https://git-scm.com/docs/git-describe#Documentation/git-describe.txt---tags) like we do for the Version.

k6/build-release.sh

Line 10 in 3e88e18

export VERSION=${2:-$(git describe --tags --always --dirty)}

vs.

k6/build-release.sh

Line 13 in 3e88e18

export VERSION_DETAILS=${3-"$(date -u +"%FT%T%z")/$(git describe --always --long --dirty)"}

[na--]

🤦‍♂️ Yeah, that is probably it...

[na--]

@olegbespalov tried it in a private repo and the lack of --tags turned out to be the problem indeed.