Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic frame panic #958

Merged
merged 9 commits into from
Apr 29, 2024
Merged

fix: dynamic frame panic #958

merged 9 commits into from
Apr 29, 2024

Conversation

scottlepp
Copy link
Contributor

What this PR does / why we need it:
Fixes a bug where the dynamic framer would panic since it contains an invalid converter.

Which issue(s) this PR fixes:
Fixes https://github.com/grafana/support-escalations/issues/10115

@scottlepp scottlepp requested a review from a team as a code owner April 19, 2024 19:26
@scottlepp scottlepp requested review from gabor, yesoreyeram, gwdawson, cletter7 and Multimo and removed request for a team April 19, 2024 19:26
@scottlepp scottlepp requested a review from a team as a code owner April 19, 2024 21:39
@scottlepp scottlepp requested review from wbrowne, oshirohugo and xnyo and removed request for a team April 19, 2024 21:39
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions / suggestions.

data/sqlutil/dynamic_frame.go Outdated Show resolved Hide resolved
data/sqlutil/dynamic_frame.go Outdated Show resolved Hide resolved
data/sqlutil/dynamic_frame_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit that is not needed

data/sqlutil/dynamic_frame.go Outdated Show resolved Hide resolved
Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
@scottlepp scottlepp merged commit 0f6f235 into main Apr 29, 2024
3 checks passed
@scottlepp scottlepp deleted the dynamic-frame-panic branch April 29, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants