Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reducing the test compile 'classpath' in WhiteboxTestCompileArgumentProvider #2

Closed
jjohannes opened this issue Jun 2, 2022 · 2 comments
Labels
a:bug Something isn't working

Comments

@jjohannes
Copy link
Member

Right now we add the --module-path but do not remove the modules from the classpath. This seems to work but it is not 100% clear what happens in situation where the classpath is used as well (i.e. users add --add-reads ...=ALL-UNNAMED).
I think we could also reduce the classpath to only include the non-modules.

@jjohannes jjohannes added the a:enhancement New feature or request label Aug 18, 2022
@jjohannes
Copy link
Member Author

There is no hook for this in Gradle. If you manually add a -classpath argument in the WhiteboxTestCompileArgumentProvider there will just be two -classpath arguments passed to the compiler.

Closing this as:

  • It does not matter in a clean setup where you have no -classpath at all
  • In the --add-reads ...=ALL-UNNAMED setup (which you should avoid anyway) it still does not seem to be a problem in practice

@jjohannes jjohannes added wontfix This will not be worked on and removed a:enhancement New feature or request labels Jun 2, 2023
@jjohannes jjohannes added a:bug Something isn't working and removed wontfix This will not be worked on labels Jan 15, 2024
@jjohannes jjohannes reopened this Jan 15, 2024
@jjohannes
Copy link
Member Author

Fixed by 0c918e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant