Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Jar patching is reproducible #89

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Make Jar patching is reproducible #89

merged 1 commit into from
Dec 7, 2023

Conversation

jjohannes
Copy link
Member

If a transform runs several times on the same code base, but the transform result is not taken from cache, it now produces the exact same Jar file. Before, the timestamp of new entries – newly created Manifest, new module-info.class – was varying.

@jjohannes jjohannes added the bug Something isn't working label Dec 7, 2023
@jjohannes jjohannes merged commit 7902b5a into main Dec 7, 2023
4 checks passed
@jjohannes jjohannes deleted the reproducible-jars branch December 7, 2023 16:30
jjohannes added a commit to hashgraph/hedera-services that referenced this pull request Dec 7, 2023
jjohannes added a commit to hashgraph/hedera-services that referenced this pull request Dec 7, 2023
See: gradlex-org/extra-java-module-info#89

Fixes one of the issues discovered through #10347

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes added a commit that referenced this pull request Dec 8, 2023
jjohannes added a commit to hashgraph/hedera-services that referenced this pull request Dec 9, 2023
See: gradlex-org/extra-java-module-info#89

Fixes one of the issues discovered through #10347

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant