Introduce the retry to HTTPS access #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KengoTODA
commented
May 14, 2021
| const httpc = new httpm.HttpClient( | ||
| 'gradle/wrapper-validation-action', | ||
| undefined, | ||
| {allowRetries: true, maxRetries: 3} |
There was a problem hiding this comment.
We can find this API from here: https://github.com/microsoft/typed-rest-client/blob/f21ab8a105826b64bf5c2df81e1f341537d273c0/test/units/httptests.ts#L422
This 3 has no special intention; I just thought that the default value 1 is too less.
There was a problem hiding this comment.
Quite a reasonable change! Thanks for this!
JLLeitschuh
approved these changes
May 14, 2021
KengoTODA
commented
May 18, 2021
| @@ -26,7 +26,7 @@ | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@actions/core": "1.2.6", | |||
| "typed-rest-client": "1.7.3", | |||
| "typed-rest-client": "1.8.4", | |||
There was a problem hiding this comment.
This update is necessary because version 1.7.3 has no retry feature for network errors.
It was introduced by microsoft/typed-rest-client@06d0fc1 and released as a part of version 1.8.0.
|
I really appreciate this change. Thank you so much for contributing it! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run builds on Actions, 104.18.191.9, probably an IP address from Cloudflare, refuses connection.
Once rerun the workflow the problem can be resolved.
Here is the full log from Actions:
I assume it's related to #33, so here I'm going to propose to introduce the retry.