Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to finalize all Property when marking JVM toolchain repositories as immutable #24674

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Make sure to finalize all Property when marking JVM toolchain repositories as immutable #24674

merged 2 commits into from
Apr 7, 2023

Conversation

ljacomet
Copy link
Member

@ljacomet ljacomet commented Apr 6, 2023

@ljacomet ljacomet added in:toolchains Java Toolchains in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty labels Apr 6, 2023
@ljacomet ljacomet added this to the 8.1 RC4 milestone Apr 6, 2023
@ljacomet ljacomet self-assigned this Apr 6, 2023
@ljacomet ljacomet linked an issue Apr 7, 2023 that may be closed by this pull request
JvmToolchain repositories break parallel project import #24669
Closed
@ljacomet ljacomet force-pushed the ljacomet/gradle81/toolchains-repository-concurrent branch from 914429d to 770eee5 Compare April 7, 2023 14:12
@ljacomet ljacomet marked this pull request as ready for review April 7, 2023 14:12
@ljacomet ljacomet requested a review from a team as a code owner April 7, 2023 14:12
@ljacomet ljacomet requested a review from tresat April 7, 2023 14:12
@ljacomet
Copy link
Member Author

ljacomet commented Apr 7, 2023

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you:

@big-guy
Copy link
Member

big-guy commented Apr 7, 2023

@bot-gradle test and merge

@gradle gradle deleted a comment from ljacomet Apr 7, 2023
@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

@bot-gradle bot-gradle merged commit a63ac23 into release Apr 7, 2023
2 checks passed
@bot-gradle bot-gradle deleted the ljacomet/gradle81/toolchains-repository-concurrent branch April 7, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@big-guy big-guy big-guy approved these changes

@tresat tresat Awaiting requested review from tresat tresat was automatically assigned from gradle/bt-jvm

Assignees

@ljacomet ljacomet

Labels
in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty in:toolchains Java Toolchains
Projects
None yet
Milestone
8.1 RC4
Development

Successfully merging this pull request may close these issues.

JvmToolchain repositories break parallel project import
3 participants
@ljacomet @bot-gradle @big-guy