Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes for plugin publishing 1.2.0 #24671

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Release notes for plugin publishing 1.2.0 #24671

merged 2 commits into from
Apr 7, 2023

Conversation

ov7a
Copy link
Member

@ov7a ov7a commented Apr 6, 2023

refs #23908

@bot-gradle bot-gradle added this to the 8.2 RC1 milestone Apr 6, 2023
@ov7a ov7a requested a review from a team April 6, 2023 12:42
@ov7a ov7a changed the base branch from master to release April 7, 2023 14:30
@ov7a ov7a requested review from a team, ldaley and bamboo as code owners April 7, 2023 14:30
@ov7a ov7a requested a review from big-guy April 7, 2023 14:30
@ov7a ov7a force-pushed the ov7a/publish-plugin-validation-task-docs branch from a79c751 to 99f1d80 Compare April 7, 2023 14:34
@ljacomet ljacomet modified the milestones: 8.2 RC1, 8.1 RC4 Apr 7, 2023
@ov7a ov7a changed the title Add doc for --validate-only flag for publishPlugins task Release notes for plugin publishing 1.1.0 Apr 7, 2023
@ov7a ov7a requested a review from ljacomet April 7, 2023 14:52
ljacomet
ljacomet requested changes Apr 7, 2023
View reviewed changes
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like the release notes.

But I believe the two remarks below would improve them further:

subprojects/docs/src/docs/release/notes.md Outdated
@@ -330,6 +330,25 @@ In other types of projects, it will use the same version of Java used by the Gra

For more details, see the [user manual](userguide/codenarc_plugin.html).

### Plugin publishing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Plugin publishing
### Plugin publishing to the Gradle Plugin Portal

subprojects/docs/src/docs/release/notes.md Show resolved Hide resolved
@ov7a ov7a changed the title Release notes for plugin publishing 1.1.0 Release notes for plugin publishing 1.2.0 Apr 7, 2023
@ov7a ov7a force-pushed the ov7a/publish-plugin-validation-task-docs branch from 3c776c3 to ff1dd91 Compare April 7, 2023 15:13
ljacomet
ljacomet requested changes Apr 7, 2023
View reviewed changes
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your release notes mixes the portal and the plugin.

See proposal:

subprojects/docs/src/docs/release/notes.md Outdated Show resolved Hide resolved
@ov7a ov7a removed request for a team April 7, 2023 15:27
@ov7a ov7a removed request for a team, ldaley, bamboo and big-guy April 7, 2023 15:27
@ov7a @ljacomet
Add release notes for plugin publishing plugin 1.2.0
06231c1 
Co-authored-by: Louis Jacomet <louis@gradle.com>
@ov7a ov7a force-pushed the ov7a/publish-plugin-validation-task-docs branch from 9a1d059 to 06231c1 Compare April 7, 2023 15:31
@ljacomet
Copy link
Member

ljacomet commented Apr 7, 2023

@bot-gradle test and merge

@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

@bot-gradle bot-gradle merged commit e76b4ef into release Apr 7, 2023
2 checks passed
@bot-gradle bot-gradle deleted the ov7a/publish-plugin-validation-task-docs branch April 7, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljacomet ljacomet ljacomet approved these changes

@jbartok jbartok jbartok approved these changes

Assignees

@ov7a ov7a

Labels
None yet
Projects
None yet
Milestone
8.1 RC4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ov7a @ljacomet @bot-gradle @jbartok