Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache entries and Job Summary not written on cache-cleanup failure #990

Closed
bigdaz opened this issue Dec 12, 2023 · 0 comments
Closed

Cache entries and Job Summary not written on cache-cleanup failure #990

bigdaz opened this issue Dec 12, 2023 · 0 comments
Labels
bug Something isn't working
Milestone
2.11.0

Comments

@bigdaz
Copy link
Member

bigdaz commented Dec 12, 2023

A failure during cache-cleanup will prevent the Gradle User Home from being saved, as well as preventing the Job Summary from being written.

This leads to confusing cache behaviour: see #988
@bigdaz bigdaz added the bug Something isn't working label Dec 12, 2023
@bigdaz bigdaz added this to the 2.11.0 milestone Dec 12, 2023
@bigdaz bigdaz mentioned this issue Dec 12, 2023
Closed
@bigdaz bigdaz closed this as completed in a71aff6 Dec 12, 2023
bigdaz added a commit that referenced this issue Dec 23, 2023
@bigdaz
Handle failure in cache-cleanup
acdddbc 
Do not abort the remainder of the post-action on failure in cache-cleanup.
Instead, just log a warning and continue.

Fixes #858
Fixes #990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.11.0
Development

No branches or pull requests
1 participant
@bigdaz